Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command to clean logs directory #68

Merged
merged 4 commits into from
May 9, 2016
Merged

Conversation

OndraM
Copy link
Member

@OndraM OndraM commented Apr 30, 2016

See #63 and #67. Should be merged after #65.

The clean command is automatically invoked on run command startup, unless option --no-clean is given.

@OndraM OndraM added this to the 2.0 milestone Apr 30, 2016
@coveralls
Copy link

coveralls commented Apr 30, 2016

Coverage Status

Coverage increased (+3.9%) to 71.931% when pulling eb7e66e on OndraM:feature/clean-logs into 19e1189 on lmc-eu:2.0.

@coveralls
Copy link

coveralls commented Apr 30, 2016

Coverage Status

Coverage increased (+3.9%) to 71.931% when pulling eb7e66e on OndraM:feature/clean-logs into 19e1189 on lmc-eu:2.0.

@coveralls
Copy link

coveralls commented Apr 30, 2016

Coverage Status

Coverage increased (+4.1%) to 72.108% when pulling c36d8f2 on OndraM:feature/clean-logs into 19e1189 on lmc-eu:2.0.

@OndraM OndraM changed the title Command to clean logs directory [WIP] Command to clean logs directory Apr 30, 2016
@coveralls
Copy link

coveralls commented Apr 30, 2016

Coverage Status

Coverage increased (+4.4%) to 72.392% when pulling 0202794 on OndraM:feature/clean-logs into 19e1189 on lmc-eu:2.0.

@coveralls
Copy link

coveralls commented Apr 30, 2016

Coverage Status

Coverage increased (+4.4%) to 72.392% when pulling 375484e on OndraM:feature/clean-logs into 19e1189 on lmc-eu:2.0.

{
$finder = (new Finder())
->files()
->in($logsDir)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Omezit to jen na aktualni adresar?
$finder->depth('== 0');

http://symfony.com/doc/current/components/finder.html#directory-depth

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, why not (steward itself won't create any subdirs). But what is the usecase? Avoid deleting some custom xml files in subdirectory?

@coveralls
Copy link

coveralls commented May 4, 2016

Coverage Status

Coverage increased (+4.4%) to 72.392% when pulling 7dcfe48 on OndraM:feature/clean-logs into 19e1189 on lmc-eu:2.0.

@coveralls
Copy link

coveralls commented May 9, 2016

Coverage Status

Coverage increased (+1.0%) to 72.349% when pulling 93b3e3f on OndraM:feature/clean-logs into 0d1e1ba on lmc-eu:2.0.

@coveralls
Copy link

coveralls commented May 9, 2016

Coverage Status

Coverage increased (+1.0%) to 72.349% when pulling 9ae5895 on OndraM:feature/clean-logs into 0d1e1ba on lmc-eu:2.0.

@OndraM OndraM merged commit 82c30c8 into lmc-eu:2.0 May 9, 2016
@OndraM OndraM deleted the feature/clean-logs branch November 26, 2020 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants