Fix unit tests #1031
Merged
Fix unit tests #1031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also changed handling of SciPy version comparisons so we leverage tuples of integers instead of strings. This does not break now that the SciPy minor has gone over 1.9.
The way warnings were caught in order to report issues with spectral initialization, warnings of deprecation in dependency code forced the breakage of our own unit tests.
Now have only one single-component spectral initialization routine.
Also fix an issue with how the random_state parameter is used incoherently between clients.
|
As I am going on vacation, let's park this as a draft until I'm back. |
lmcinnes
approved these changes
Aug 17, 2023
|
Still some failing tests; they seem to have dropped off from azure; Should I just merge as is and we can fix the last few tests if they are still failing? |
The exact number is not critical, so any matching warning _can_ be issued more than once.
|
One of the remaining issues I know is fixed by @lmcinnes (who is waiting on this PR to merge it). The other one has to do with the numerical behaviour of the spectral initializer on MacOS. I'll inspect this one out of this PR, so I call a merge of this. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes unit tests that had decayed because of some unsound warning handling and deprecations in dependency calling contracts. It also refactors the
umap.spectralcomprehensively, removing code duplication and improving the legibility of alternative approaches to spectral initialization of the low-space embedding.