Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc Model improvements... #58

Merged
merged 4 commits into from Dec 13, 2013
Merged

Misc Model improvements... #58

merged 4 commits into from Dec 13, 2013

Conversation

danielballan
Copy link
Member

  • API: N=Parameter(value=7) is equivalent to N=Parameter(name='N', value=7).
  • CLN/PERF: Build residual only once, on instantiation.
  • ENH: Allow models with no independent_vars.
  • ENH: Support weighted fits.
  • BUG: Copy parameters on input.
  • ENH: Handle missing data.
  • BUG: Accept pandas.Series equivalently to numpy.ndarray.

* API: ``N=Parameter(value=7)`` is equivalent to ``N=Parameter(name='N', val
* CLN/PERF: Build residual only once, on instantiation.
* ENH: Allow models with no independent_vars.
* ENH: Support weighted fits.
* BUG: Copy parameters on input.
* ENH: Handle missing data.
* BUG: Accept pandas.Series equivalently to numpy.ndarray.
@danielballan
Copy link
Member Author

Here's a link to the updated notebook on nbviewer (updated with plotting from commit below)

@danielballan
Copy link
Member Author

After tagging on those few commits to make the feature set more complete and consistent, I think this is ready to merge.

newville added a commit that referenced this pull request Dec 13, 2013
Misc Model improvements...
@newville newville merged commit 51be637 into lmfit:master Dec 13, 2013
@newville
Copy link
Member

Great! Thanks... Today's been a bit busy for me, so I'll try to comment on
many of the suggestions here in one email:

a) I completely understand not wanting to get too over-committed.
b) I like your suggestion of sublcassing from Model and being able to
"add Models".
c) I've never really loved the "scikits.something" names, but I think we
need a github organization. I think "lmfit" is a little too narrow for
much of what is happening here (better Models, Error Analysis, and so on),
but is "lmfit" OK as an organization name? Perhaps we could start with
that and work on a better name?

--Matt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants