Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make Parameter.vary a property #860

Merged
merged 2 commits into from
Apr 7, 2023
Merged

make Parameter.vary a property #860

merged 2 commits into from
Apr 7, 2023

Conversation

newville
Copy link
Member

@newville newville commented Apr 5, 2023

This makes Parameter.vary into a property, wrapping an underlying ._vary attribute, so that setting Parameter.vary=True will erase an existing constraint expression

This addresses the problem described in #859

Description

Type of Changes
  • Bug fix
  • New feature
  • Refactoring / maintenance
  • Documentation / examples
Tested on

Python: 3.11.0 | packaged by conda-forge | (main, Jan 15 2023, 05:44:48) [Clang 14.0.6 ]

lmfit: 1.2.0rc1.post0+g52012fd.d20230405, scipy: 1.10.1, numpy: 1.24.2, asteval: 0.9.29, uncertainties: 3.1.7

Verification

Have you

  • included docstrings that follow PEP 257?
  • referenced existing Issue and/or provided relevant link to mailing list?
  • verified that existing tests pass locally?
  • verified that the documentation builds locally?
  • squashed/minimized your commits and written descriptive commit messages?
  • added or updated existing tests to cover the changes?
  • updated the documentation and/or added an entry to the release notes (doc/whatsnew.rst)?
  • added an example?

@codecov
Copy link

codecov bot commented Apr 5, 2023

Codecov Report

Merging #860 (8e5c5d2) into master (52012fd) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #860      +/-   ##
==========================================
+ Coverage   93.53%   93.54%   +0.01%     
==========================================
  Files          10       10              
  Lines        3602     3610       +8     
==========================================
+ Hits         3369     3377       +8     
  Misses        233      233              
Impacted Files Coverage Δ
lmfit/parameter.py 99.03% <100.00%> (+0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant