Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove heading tags in html table #883

Closed

Conversation

simonkeys
Copy link
Contributor

Description

The html fit reports contain h2 tags, which are interpreted as section headings by the table of contents sidebar of JupyterLab. I'm assuming that's undesirable behavior for everyone, so I just replaced the h2 tags with b.

If there is a specific reason for the h2 tags, I could instead add function parameters to specify which tag is desired.

Type of Changes
  • Bug fix
  • New feature
  • Refactoring / maintenance
  • Documentation / examples
Tested on

Python: 3.8.15 | packaged by conda-forge | (default, Nov 22 2022, 08:53:40)
[Clang 14.0.6 ]
lmfit: 1.2.1.post1+ga246cbc7, scipy: 1.9.3, numpy: 1.23.5, asteval: 0.9.28, uncertainties: 3.1.7

Verification

Have you

  • included docstrings that follow PEP 257?
  • referenced existing Issue and/or provided relevant link to mailing list?
  • verified that existing tests pass locally?
  • verified that the documentation builds locally?
  • squashed/minimized your commits and written descriptive commit messages?
  • added or updated existing tests to cover the changes?
  • updated the documentation and/or added an entry to the release notes (doc/whatsnew.rst)?
  • added an example?

@newville
Copy link
Member

@simonkeys I'm afraid that it is not obvious to me why using h2 is undesirable. If the HTML contents of Jupyter cells cannot have headings, that seems like a Jupyter error to me.

Anyway, <b> is a text-formatting directive, whereas <hN> gives a semantic directive. They are not really interchangeable. Perhaps using <h3> or <h4> would be better?

Being able to reference a Discussion or clearly identified Issue is greatly preferred for PRs.

@reneeotten
Copy link
Contributor

I have never used Jupyterlab and friends - in fact, I just tried it to see what the HTML report would look like and cannot get it to do anything so I have no idea ;)

Anyway, the original proposal for this code was by @Tillsten so I assume that he is using it and therefore perhaps can comment on the reported issue and proposed solution?

@newville
Copy link
Member

@reneeotten @simonkeys @Tillsten I think we need a demonstration of a problem before we can assess any proposed solutions. Please create a discussion on this topic.

@simonkeys
Copy link
Contributor Author

I have started a discussion (#884). Apologies for skipping this step earlier.

@newville
Copy link
Member

@simonkeys @reneeotten Any thoughts on getting this to a point of completion?

@newville
Copy link
Member

newville commented Jul 7, 2023

superseded by #902

@newville newville closed this Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants