-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Html repr with JupyterLab TOC #902
Conversation
Codecov Report
@@ Coverage Diff @@
## master #902 +/- ##
==========================================
- Coverage 93.23% 93.23% -0.01%
==========================================
Files 10 10
Lines 3683 3693 +10
==========================================
+ Hits 3434 3443 +9
- Misses 249 250 +1
|
The PR addresses the issue from #883 (e.g. the lmfit output adding many sections to the table of contents). The formatting style is off course subjective, but it looks good to me. The only thing that bothers me a bit is the final caption (for Correlations) that is split between two lines for no apparent reason. |
@eendebakpt I updated the HTML generation to have column headers for the correlation table, which should help, and to left-align most of the text. If you find this acceptable, I'll merge this in. |
@newville looks good to me! Can you please do a "squash-and-merge" and update the commit message so we're not left with all the mess (after all this should just be one commit anyway) 😉 |
@reneeotten yep, I will squash and merge. |
]
Description
This should replace #883, and follows from discussion #884
Type of Changes
Tested on
Verification
Have you