Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI/BLD changes #928

Merged
merged 2 commits into from
Dec 1, 2023
Merged

Conversation

reneeotten
Copy link
Contributor

Description

  • test using the released version of Python 3.12, added Python 3.13-dev
  • remove setup.cfg in favor of pyproject.toml
Type of Changes
  • Bug fix
  • New feature
  • Refactoring / maintenance
  • Documentation / examples
Tested on

Python: 3.11.6 (main, Oct 3 2023, 00:01:08) [Clang 15.0.0 (clang-1500.0.40.1)]

lmfit: 1.2.2.post18+gf5f1e278, scipy: 1.11.4, numpy: 1.26.2, asteval: 0.9.31, uncertainties: 3.1.7-->

Verification

Have you

  • included docstrings that follow PEP 257?
  • referenced existing Issue and/or provided relevant link to mailing list?
  • verified that existing tests pass locally?
  • verified that the documentation builds locally?
    The documentation builds locally but on the CI there appears to be an issue. I haven't figured out completely what the issue is, but it's for sure unrelated to this PR.
  • squashed/minimized your commits and written descriptive commit messages?
  • added or updated existing tests to cover the changes?
  • updated the documentation and/or added an entry to the release notes (doc/whatsnew.rst)?
  • added an example?

Copy link

codecov bot commented Nov 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e21a6aa) 93.17% compared to head (af16a01) 93.17%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #928   +/-   ##
=======================================
  Coverage   93.17%   93.17%           
=======================================
  Files          10       10           
  Lines        3690     3690           
=======================================
  Hits         3438     3438           
  Misses        252      252           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@newville
Copy link
Member

newville commented Dec 1, 2023

@reneeotten this all seems okay to me. I'm not sure if there is a concrete benefit from moving content from setup.cfg to pyproject.toml, but the difference between the two has always confused me. I don't have any objection to doing that.

It seems like the docs not building is a separate CI thing.... should we just merge this?

@reneeotten reneeotten merged commit caf0930 into lmfit:master Dec 1, 2023
14 of 16 checks passed
@reneeotten
Copy link
Contributor Author

The CI failure for the documentation is real, I can reproduce this locally as well with the latest dependencies.

I have't been able to pinpoint the exact cause, but will try to take another look in the weekend.

@reneeotten reneeotten deleted the switch-to-pyproject.toml branch December 1, 2023 14:01
@newville
Copy link
Member

newville commented Dec 1, 2023

@reneeotten OK. FWIW, I just pulled master to my local environment (macOS, Python 3.11.5), and docs did build, but gave some debugger messages that I did not recognize.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants