Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Message struct uses incorrect names when marshaling to JSON. #117

Closed
nthpool opened this issue Mar 4, 2024 · 1 comment · Fixed by #127
Closed

Message struct uses incorrect names when marshaling to JSON. #117

nthpool opened this issue Mar 4, 2024 · 1 comment · Fixed by #127
Assignees
@lmittmann
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@nthpool
Copy link

nthpool commented Mar 4, 2024

Hello,

When marshaling the Message struct to JSON i noticed that the GasFeeCap & GasTipCap fields are marshaled as gasFeeCap & gasTipCap which is incompatible with some of geth's RPC methods which take TransactionArgs as a parameter:

This causes GasFeeCap & GasTipCap fields in the message struct to be ignored by geth.
@lmittmann
Copy link
Owner

Good catch. PRs welcome.

@lmittmann lmittmann added the good first issue Good for newcomers label Mar 8, 2024
@lmittmann lmittmann added the bug Something isn't working label Mar 30, 2024
@lmittmann lmittmann self-assigned this Mar 30, 2024
lmittmann added a commit that referenced this issue Mar 30, 2024
@lmittmann
w3types: fixed incorrect Message struct names when marshaling to JSON.
5ddf1cc 
fixes #117
@lmittmann lmittmann mentioned this issue Mar 30, 2024
Merged
lmittmann added a commit that referenced this issue Mar 30, 2024
@lmittmann
w3types: Fixed incorrect Message struct names when marshaling to JSON (…
fcc89b4 
…#127)

fixes #117

Co-authored-by: lmittmann <lmittmann@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lmittmann lmittmann

Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

w3types: Fixed incorrect Message struct names when marshaling to JSON lmittmann/w3
2 participants
@lmittmann @nthpool