Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Finnish i18n translation #2228

Merged
merged 2 commits into from
Feb 2, 2024
Merged

Implement Finnish i18n translation #2228

merged 2 commits into from
Feb 2, 2024

Conversation

tlindi
Copy link
Contributor

@tlindi tlindi commented Feb 1, 2024

Create i18n/fi.js initial version - FOSS ftw

@tlindi tlindi force-pushed the add-finnish branch 3 times, most recently from 5d7554b to 6817505 Compare February 1, 2024 01:27
@prusnak
Copy link
Collaborator

prusnak commented Feb 1, 2024

Please also run make bundle and add the result as the new commit with commit message: chore: make bundle

@tlindi
Copy link
Contributor Author

tlindi commented Feb 1, 2024

Please also run make bundle and add the result as the new commit with commit message: chore: make bundle

This was somewhat had for as I'm not experienced at all with poetry and such programming tools :-/ I tried to get "make" to complete. But unfor my skills lack. Best I got was

"The currently activated Python version 3.8.9 is not supported by the project (^3.10 | ^3.9)."
Unfortunately I don't have additional OS to create more recent compile environment and time is scarce too. Learnig curve is too steep for me. What to do?

@prusnak
Copy link
Collaborator

prusnak commented Feb 1, 2024

What to do?

Okay, I did that for you and pushed to your PR branch.

Copy link

codecov bot commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (43d92dd) 57.77% compared to head (797ff21) 59.24%.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2228      +/-   ##
==========================================
+ Coverage   57.77%   59.24%   +1.46%     
==========================================
  Files          60       60              
  Lines        9017     9017              
==========================================
+ Hits         5210     5342     +132     
+ Misses       3807     3675     -132     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tlindi tlindi force-pushed the add-finnish branch 3 times, most recently from 1d79039 to 18f91a9 Compare February 1, 2024 03:07
@tlindi
Copy link
Contributor Author

tlindi commented Feb 1, 2024

restored changes @prusnak had made and fixed one typo to make prettifier happy.

@prusnak
Copy link
Collaborator

prusnak commented Feb 1, 2024

restored changes @prusnak had made and fixed one typo to make prettifier happy.

You did not. The file bundle.js is not part of your change. Why did you override my changes in the first place?

@tlindi
Copy link
Contributor Author

tlindi commented Feb 1, 2024

restored changes @prusnak had made and fixed one typo to make prettifier happy.

You did not. The file bundle.js is not part of your change. Why did you override my changes in the first place?

Uuh.. by mistake. cause I'm so bad at this :'-( I'll stop now. Hopefully this translation some day finds it way to release.

@prusnak prusnak requested a review from dni February 1, 2024 17:42
@dni
Copy link
Member

dni commented Feb 2, 2024

thanks 👍

@prusnak prusnak merged commit 311d9a6 into lnbits:dev Feb 2, 2024
22 checks passed
@tlindi tlindi deleted the add-finnish branch February 4, 2024 15:06
@tlindi tlindi mentioned this pull request Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants