Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Finnish grammar #2241

Merged
merged 2 commits into from
Feb 6, 2024
Merged

Conversation

tlindi
Copy link
Contributor

@tlindi tlindi commented Feb 6, 2024

Updates #2228

@tlindi tlindi force-pushed the fixes-to-Finnish-translation branch from 2f018dd to 2430e04 Compare February 6, 2024 13:53
@tlindi
Copy link
Contributor Author

tlindi commented Feb 6, 2024

Unfor test fails and fixing it is above my skill level. on my machine make checkbundle passes
...

diff -q lnbits/static/bundle.min.js lnbits/static/bundle.min.js.old || exit 1
diff -q lnbits/static/bundle.min.css lnbits/static/bundle.min.css.old || exit 1
Bundle is OK
rm lnbits/static/bundle.min.js.old
rm lnbits/static/bundle.min.css.old

@prusnak prusnak force-pushed the fixes-to-Finnish-translation branch from 1215bc4 to c9f29e3 Compare February 6, 2024 14:49
@prusnak
Copy link
Collaborator

prusnak commented Feb 6, 2024

Unfor test fails and fixing it is above my skill level. on my machine make checkbundle passes

You were not on the latest dev (your dev was older than our dev).

I rebased on top of our dev and pushed to your branch.

@tlindi
Copy link
Contributor Author

tlindi commented Feb 6, 2024

I was close to solve the issue myself - maybe next time ;-)

Thank you 🙏

@prusnak prusnak requested a review from dni February 6, 2024 14:59
@prusnak prusnak added this to the 0.12.0 milestone Feb 6, 2024
Copy link

codecov bot commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (59968e3) 59.20% compared to head (c9f29e3) 59.23%.
Report is 1 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2241      +/-   ##
==========================================
+ Coverage   59.20%   59.23%   +0.02%     
==========================================
  Files          60       60              
  Lines        9021     8992      -29     
==========================================
- Hits         5341     5326      -15     
+ Misses       3680     3666      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@prusnak prusnak merged commit 94f74d3 into lnbits:dev Feb 6, 2024
22 checks passed
@tlindi tlindi deleted the fixes-to-Finnish-translation branch February 6, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants