Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Now preconfigured Verilog wrapper can handle config_enable signals correctly #556

Merged
merged 4 commits into from
Feb 24, 2022

Conversation

tangxifan
Copy link
Collaborator

@tangxifan tangxifan commented Feb 23, 2022

Motivate of the pull request

  • To address an existing issue. If so, please provide a link to the issue:
  • Breaking new feature. If so, please describe details in the description part.

Describe the technical details

What is currently done? (Provide issue link if applicable)

Currently, OpenFPGA has the following limitations:

  • config_enable ports of circuit models are not handled correctly in preconfigured Verilog wrapper
    • config_enable signals are designed to be pulled up/down once FPGA bitstream loading is done. In OpenFPGA architecture description, their default values are given as the initial values to be set when bitstream loading is ongoing.
    • However, in preconfigured wrappers. The configuration is already done. So the config_enable signals should be set to the default values. Instead, they should be set to the opposite to the default values

What does this pull request change?

This PR improves in the following aspects:

  • Now preconfigured Verilog wrapper can handle config_enable signals correctly
  • Update documentation on the config_enable signals, regarding their values in testbenches
  • Add dedicated test cases to validate this feature

Which part of the code base require a change

  • VPR
  • Tileable routing architecture generator
  • OpenFPGA libraries
  • FPGA-Verilog
  • FPGA-Bitstream
  • FPGA-SDC
  • FPGA-SPICE
  • Flow scripts
  • Architecture library
  • Cell library
  • Documentation
  • Regression tests
  • Continous Integration (CI) scripts

Impact of the pull request

  • Require a change on Quality of Results (QoR)
  • Break back-compatibility. If so, please list who may be influenced.

@tangxifan tangxifan changed the title Now preconfigured Verilog wrapper can handle config_enable signals correctly [WIP] Now preconfigured Verilog wrapper can handle config_enable signals correctly Feb 23, 2022
@tangxifan tangxifan changed the title [WIP] Now preconfigured Verilog wrapper can handle config_enable signals correctly Now preconfigured Verilog wrapper can handle config_enable signals correctly Feb 24, 2022
@tangxifan tangxifan merged commit 3cc2bc9 into master Feb 24, 2022
@tangxifan tangxifan deleted the tb branch February 24, 2022 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant