-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug in v1.16.4 when lift_title=False
broke auto_definitions
#50
Comments
Not so sure it is lift_definitions per se. The thing is that to have a working reference you need to have a title using Could you please try the different combinations? |
Assuming a schema with definitions and directives referencing with json-pointer, and without thoroughly digging into each case below, this is the situation:
Do that make sense? Or i should do elaborate testing? |
That is kind of what I expected except the second case, I would expect that one to work. |
Given this schema:
Tests and results:I suppose your issue is with cases 9 and 10. Is that correct? I would have thought that the combination of The (surprising) case 4 suggests a temporary solution for you.
|
Thanks. |
I have found the cause the new introduced option |
(ok, my last message meshed it up)
And i confirm that if all the rest are true, To be succinct, the workaround no4 does not work when schema reuses definitions. |
To prevent messing it up any further but quickly answer your earlier message |
It's a bit annoying how docutils reports broken links but the Regarding case 4 the schema used has a $$target that's equal to the definition if |
case 4: except that lift_title was False. That was the surprising bit for me. |
With latest
v1.16.4
and config-options:"lift_title": False,
"lift_definitions": True,
"auto_reference": True,
"auto_target": True,
... then the
auto_definitions=True
does not work -- all definition references are reported asTurning
lift_title=True
fixes the problem, but then one cannot take advantage of this setting.The text was updated successfully, but these errors were encountered: