CI: downgrade to v18 #514
Merged
CI: downgrade to v18 #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The change done in [1] is good because 14.x version was too old, but 20.x is too new. The new Ubunutu LTS, released last month, doesn't even have such a bleeding edge Node version. Let's downgrade to 18.x which is a good sweet spot: new enough, but also stable enough. This way we make sure LNp2pBot is compatible with the same version of NodeJS shipped by the last Ubuntu LTS. [1] 439d043
|
Oops, I'll look at the CI failure soon; don't merge. |
Mongoose couldn't resolve localhost for some reason. The CI problem was fixed after replacing localhost with 127.0.0.1.
|
@grunch this is ready now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change done in [1] is good because 14.x version was too old, but 20.x is too new. The new Ubunutu LTS, released last month, doesn't even have such a bleeding edge Node version. Let's downgrade to 18.x which is a good sweet spot: new enough, but also stable enough.
This way we make sure LNp2pBot is compatible with the same version of NodeJS shipped by the last Ubuntu LTS.
[1] 439d043