-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
commands: inform buyer when order is canceled #519
base: main
Are you sure you want to change the base?
Conversation
When the seller cancels an order, the buyer was getting a confusing message: ``` You have cancelled the order ID: orderID ``` Now the bot sends a message that tells the buyer: ``` Order orderId has been cancelled. There is no need to create an invoice. ``` Fixes: lnp2pBot#482
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a good add, thank you @knocte
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is something we need to do before start using this, we need this new message to be added on the other languages, if we don't it will fail to users with non english settings
But I only speak 2 languages :) why don't you use automatic tools for this such as Transifex? |
yeah me too, currently I'm translating manually new locales, do you have a guide to implement transifex here, if you can give us a hand on this it would be great 😃 |
What do you exactly mean with "translating manually"? Don't tell me you're using ChatGPT 😛
No TBH. I come from the GNOME ecosystem, where all kinds of gettext-style tools were already integrated in the workflow, and only native speakers did the translation work. Then I learned about Transifex from the fact that Smuxi (a GNOME IRC client I contributed to) also received translations this way.
I'll try gathering more info about how a new project can join any of these systems. |
BTW, I brought this up because when using gettext, for example, if the repo gains new strings from a PR, the default text is always in English, but gains some metadata that the translators can pull, to know that their translations got outdated, and when a translation hasn't been updated yet, at least it would show in English (instead of empty or throwing an error). |
haha no, I'm using this one |
makes sense, in our case we should code it, |
When the seller cancels an order, the buyer was getting a confusing message:
Now the bot sends a message that tells the buyer:
Fixes: #482