Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add no-identical-title rule (fixes #33) #97

Merged
merged 2 commits into from
Aug 27, 2016

Conversation

jfmengels
Copy link
Collaborator

Add no-identical-title rule (fixes #33)

I decided to name it no-identical-title to be "consistent" with eslint-plugin-ava's similar rule. Let me know if you prefer it to be no-duplicate-title or something else.


## Rule Details

This rule looks at the rule of every test and test suites. It will report when two test suites or two test cases at the same level of a test suite have the same name.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess rule should be title or name, right?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely. And name should probably be title too.

@jfmengels
Copy link
Collaborator Author

Fixed. By the way, I'd recommend squashing PRs in order to keep the commit history clean.

@lo1tuma lo1tuma merged commit 42d1322 into lo1tuma:master Aug 27, 2016
@lo1tuma
Copy link
Owner

lo1tuma commented Aug 27, 2016

Merged. Thank you.

I also squashed the commits of this PR but I guess my changelog tool pr-log won’t work with this as it looks specifically for merge commits on master in order to create the changelog. Anyway shouldn’t be a problem to create the changelog manually for the next release.

@jfmengels jfmengels deleted the no-identical-title branch August 27, 2016 14:59
@jfmengels
Copy link
Collaborator Author

You're welcome :)

Ah, right. Yeah, should be fine in this case, but that's too bad. Maybe try looking at a different tool to does not rely on merge commits, because a flat commit history is really nice IMO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Forbid duplicate test names
2 participants