[dv/hmac] hmac_done check #749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add checkings for hmac_done Add checkings to enable and disable cycle accurate checking Re-org some process to make the scb more efficient: only flush and check when seeing hmac_process
weicaiyang
reviewed
Nov 1, 2019
| bit write = item.is_write(); | ||
| uvm_reg_addr_t csr_addr = get_normalized_addr(item.a_addr); | ||
| bit do_read_check = 1'b1; | ||
| bit do_cycle_accurate_check = 1'b1; |
There was a problem hiding this comment.
this variable is constant 1, do you create it for future use?
|
Thanks for checking Weicai! Yes it is when design optimize the code in the
next stage, this won’t be passing again. Just for the ease of debug :)
…On Thu, Oct 31, 2019 at 8:42 PM weicaiyang ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In hw/ip/hmac/dv/env/hmac_scoreboard.sv
<#749 (comment)>:
> @@ -27,9 +27,10 @@ class hmac_scoreboard extends cip_base_scoreboard #(.CFG_T (hmac_env_cfg),
virtual task process_tl_access(tl_seq_item item, tl_channels_e channel = DataChannel);
uvm_reg csr;
- bit do_read_check = 1'b1;
- bit write = item.is_write();
- uvm_reg_addr_t csr_addr = get_normalized_addr(item.a_addr);
+ bit do_read_check = 1'b1;
+ bit do_cycle_accurate_check = 1'b1;
this variable is constant 1, do you create it for future use?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#749?email_source=notifications&email_token=ACXPOOLATH3U6HOB2YGQPZLQROQSDA5CNFSM4JHUX2BKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCJ7H7UQ#pullrequestreview-310280146>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACXPOONBR6BMUZS6UV2UPJ3QROQSDANCNFSM4JHUX2BA>
.
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add checkings for hmac_done
Add checkings to enable and disable cycle accurate checking
Re-org some process to make the scb more efficient: only flush and check
when seeing hmac_process