bug: Ensure all containers drained before exiting #56

jrconlin · 2017-04-11T22:23:10Z

closes #45

jrconlin · 2017-04-11T22:23:53Z

serverless.yml

+                - UndrainedInstancesException
+              IntervalSeconds: 10
+              MaxAttempts: 10
+              BackoffRate: 1


Honestly not sure if this needs a catch. It's the last step, so an error should fail out anyway.

It doesn't need a catch, but it does need the retry. I assume 100 seconds should be enough for it to complete.

bbangert · 2017-04-11T22:25:48Z

handler.py

+
+
+def check_drain(event, context):
+    return AsynchronousPlanRunner(event, context).check_drained()


Needs a line-break at the end.

bbangert · 2017-04-11T22:26:31Z

serverless.yml

+                - UndrainedInstancesException
+              IntervalSeconds: 10
+              MaxAttempts: 10
+              BackoffRate: 1


It doesn't need a catch, but it does need the retry. I assume 100 seconds should be enough for it to complete.

closes #45

jrconlin requested a review from bbangert April 11, 2017 22:23

chartjes added the in progress label Apr 11, 2017

jrconlin commented Apr 11, 2017

View reviewed changes

bbangert reviewed Apr 11, 2017

View reviewed changes

bug: Ensure all containers drained before exiting

4cbea2f

closes #45

jrconlin force-pushed the bug/45 branch from f52ec1f to 4cbea2f Compare April 11, 2017 23:10

bbangert approved these changes Apr 11, 2017

View reviewed changes

jrconlin merged commit 067bedc into master Apr 11, 2017

chartjes removed the in progress label Apr 11, 2017

bbangert deleted the bug/45 branch April 11, 2017 23:23

Provide feedback



		def check_drain(event, context):
		return AsynchronousPlanRunner(event, context).check_drained()