This repository has been archived by the owner on Oct 24, 2020. It is now read-only.
bug: Do not check 'metrics' instance for draining #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #60 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 4 4
Lines 483 488 +5
=====================================
+ Hits 483 488 +5
Continue to review full report at Codecov.
|
bbangert
reviewed
Apr 19, 2017
ardere/aws.py
Outdated
| Optional, | ||
| Tuple | ||
| ) # noqa | ||
| from typing import (Any, Dict, List, Optional, Tuple) # noqa |
Also fixed some flake8 errors closes #59
bbangert
approved these changes
Apr 20, 2017
bbangert
reviewed
Apr 20, 2017
| status="ACTIVE", | ||
| ).get('containerInstanceArns', []) | ||
| # filter out metric servers | ||
| if self.event["metrics_options"]["enabled"]: |
There was a problem hiding this comment.
The shutdown plan already locates the metrics service, we should probably determine when we call it the first time and stick it in the event to avoid having to keep searching (and slowing execution time).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixed some flake8 errors
closes #59