Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify CI config #24

Merged
merged 2 commits into from
Aug 26, 2018
Merged

Simplify CI config #24

merged 2 commits into from
Aug 26, 2018

Conversation

davidanthoff
Copy link
Collaborator

This slightly simplifies and follows standard CI config.

Mainly, though, I just want to trigger a build and see how we are doing :)

@lobingera
Copy link
Owner

lobingera commented Aug 25, 2018

To make a longer story short: We failed on 0.7/1.0 OSX for Cairo homebrew issues. You can follow the discussion here: JuliaGraphics/Cairo.jl#250

@davidanthoff
Copy link
Collaborator Author

Can we merge this PR, and then tag a release? That would lead to a strictly better situation than what we have now: we would then have a working 0.7/1.0 version for Win and Linux, and we wouldn't break anything that works right now.

It would help me to move forward with the whole VegaLite.jl compat work for 0.7/1.0.

@davidanthoff
Copy link
Collaborator Author

Actually, Windows on 1.0 is also not working, probably needs JuliaPackaging/WinRPM.jl#158. But I think we could still merge this PR and tag a release, at least things would work on 0.7... And once the WinRPM situation is solved, it should just start working on 1.0 as well.

@lobingera
Copy link
Owner

@davidanthoff I made recently some experiences with releasing something that was not available on all platforms and if we do that now for Rsvg i guess i can count the minutes before the first issues arrive. If testing is positive on 2 of 3 platforms for 1.0 i'd do a release. Solving homebrew for Cairo seems to be not far away.

@lobingera lobingera merged commit 986f07e into lobingera:master Aug 26, 2018
@davidanthoff davidanthoff deleted the ci-config branch August 26, 2018 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants