Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to backstage v1.6.0 & remove unnecessary react-router dep #190

Closed
wants to merge 1 commit into from
Closed

Add support to backstage v1.6.0 & remove unnecessary react-router dep #190

wants to merge 1 commit into from

Conversation

ivangonzalezacuna
Copy link

Added support to the latest version of backstage.

This change is really important, and many people might face issues upgrading their plugin in the near future.

Also, I removed the react-router dependency and, consequently, a few lines in the Router.ts file, as this is not needed to display the GitlabCi component.

@NishkarshRaj
Copy link
Contributor

@satrox28 this is very important for any adopter to perform: https://backstage.io/docs/tutorials/react-router-stable-migration if they are using GitLab Plugin.

@FlxPeters
Copy link

Any news on this? We have the same issue and i would like to update to the current backstage version.
Thanks for your PR @ivangonzalezacuna!

@satrox28
Copy link
Collaborator

@richardmcsong please take a look.

@ivangonzalezacuna
Copy link
Author

Hi. Any update on this? We would really like to get rid of the beta version of react router and update to the latest version of backstage (1.7.0 already)

@djetelina
Copy link

Let me bump this, as I started playing around with backstage starting with 1.6.0, this plugin never worked for me. Does Loblaw plan to maintain the plugin, or should the community start thinking about a fork?

@testn
Copy link

testn commented Nov 17, 2022

@satrox28 Would you mind help looking into this issue?

@AlexPerkbox
Copy link

Can anyone approve this please? It is blocking gitlab's integration in backstage's newest release.

@xuanyue202
Copy link

xuanyue202 commented Nov 27, 2022

As a workaround, I created a mimic lib tested with backstage v1.8.0. You can use this lib while waiting for the official one to be updated.

https://www.npmjs.com/package/backstage-plugin-gitlab

@satrox28
Copy link
Collaborator

satrox28 commented Nov 29, 2022

Hi All,

I am no longer with the Organization, have informed the required folks, please allow sometime for them to respond here.

@devops-systems-com
Copy link

As a workaround, I created a mimic lib tested with backstage v1.8.0. You can use this lib while waiting for the official one to be updated.

https://www.npmjs.com/package/backstage-plugin-gitlab
Please can you provide a link to the mimic lib as the posted link just goes back to the same broken version by loblaw

@sbarrypoppulo
Copy link

Is it possible to get this PR reviewed and merged so latest package is published and can be consumed in Backstage 1.6.0+?

@JellyBellyDev
Copy link

Hi guys!
not having received replies and feedback, as promised, we forked with the commitment to maintain the plugin more actively.
We hope that the plugin user community will follow and support us.
You can find us at the following links:
https://github.com/immobiliare/backstage-plugin-gitlab
https://www.npmjs.com/package/@immobiliarelabs/backstage-plugin-gitlab
Thanks! 🚀

@ivangonzalezacuna ivangonzalezacuna closed this by deleting the head repository Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.