Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.x] Try to fix update test #637

Merged
merged 5 commits into from
Nov 8, 2023
Merged

[3.x] Try to fix update test #637

merged 5 commits into from
Nov 8, 2023

Conversation

andybroomfield
Copy link
Contributor

Add :void to update test

Referencing https://git.drupalcode.org/project/drupal/-/merge_requests/4278/diffs#85d25f5dc63bb563be005f32257870110dac218a to try and resolve the update error.

@andybroomfield
Copy link
Contributor Author

Test is failing becuase geofield_map missing, assume its in the DB dump so adding as a dev dependency.

Requirements problem
Status Details
Errors found
Missing or invalid module
The following module is marked as installed in the core.extension configuration, but it is missing:
geofield_map

Review the suggestions for resolving this incompatibility to repair your installation, and then re-run update.php.

@andybroomfield
Add geofield map as a profile dev dependancy
9c18936 
This is requires as the update test will update from a DB that includes
geofield_map, so have it installed when running tests.
@andybroomfield
Try to obtain dev dependencies
d7a9ee4
@andybroomfield
Bump geofield map dev dependancy to 3.0
e510f92 
Since it's only needed to make sure the update is run, it shouldn't matter
which version so use a PHP 8.2 compataible one.
@andybroomfield
Copy link
Contributor Author

This is now working except for a PHP 8.2 error which looks to be generated by entity_browser so this should be good for review and inclusion ahead of release.

@andybroomfield andybroomfield changed the title Try to fix update test [3.x] Try to fix update test Nov 7, 2023
@andybroomfield andybroomfield mentioned this pull request Nov 7, 2023
Closed
6 tasks
@finnlewis
Copy link
Member

Happy to merge this. There is one failing test, on the update https://github.com/localgovdrupal/localgov/actions/runs/6786718690/job/18491342397#step:5:19

@ekes points out that this is only in our update test and we will be removing that in favour of a new update test soon.

@finnlewis finnlewis merged commit 1938bd9 into 3.x Nov 8, 2023
7 of 8 checks passed
@finnlewis finnlewis deleted the fix/3.x-try-to-fix-update-test branch November 8, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephen-cox stephen-cox Awaiting requested review from stephen-cox

@ekes ekes Awaiting requested review from ekes

@finnlewis finnlewis Awaiting requested review from finnlewis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andybroomfield @finnlewis