Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch Preview Link module for 'Automatically populating multiple preview link entities' #713

Merged
merged 3 commits into from
Jun 18, 2024

Conversation

stephen-cox
Copy link
Member

@stephen-cox stephen-cox commented May 21, 2024

@stephen-cox
Copy link
Member Author

Marking as draft as I need to add some tests and then we can lock the patch file to a specific commit.

@stephen-cox stephen-cox marked this pull request as ready for review May 22, 2024 13:42
@stephen-cox
Copy link
Member Author

This is now ready for review.

This PR simply patches Preview Link. To see it in action you also need the plugins in Guides and Step by Steps which are here:

@stephen-cox
Copy link
Member Author

There are also PRs adding populate preview link buttons to Directories (localgovdrupal/localgov_directories#376) and Subsites (localgovdrupal/localgov_subsites#146)

@stephen-cox
Copy link
Member Author

@ekes @finnlewis Would be nice to get this reviewed and merge 😄

@ekes
Copy link
Member

ekes commented Jun 18, 2024

I'd missed this patch. Testing with step-by-step first.

My note on subsites, about levels/depth, still stands though.

Copy link
Member

@ekes ekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK so we're already similarly patching this module, so we're hooked there already.
Looked at the plugin and tests and all looks good. Also tested with step-by-step and directories manually.

@finnlewis finnlewis merged commit 4b409e3 into 3.x Jun 18, 2024
8 checks passed
@finnlewis finnlewis deleted the feature/3.x/600-patch-preview-link branch June 18, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants