Added PreviewLinkAutopopulate plugin to auto-populate preview links #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note depends on localgovdrupal/localgov#713 |
ekes
approved these changes
Jun 18, 2024
There was a problem hiding this comment.
Sensible this only works down, and it works. So approving but one question:
Is this potentially making a button that might crash the site? Unlike step by step and guides can we expect huge numbers of nodes, and at what point is the loadByProperties or the form itself going die? I guess it's not so important.
|
Note: it would be great to add a test for performance limitations on this. How many is too many entities? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of localgovdrupal/localgov#600