Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move the getCurrentAlertBanners method to a service #261

Closed
andybroomfield opened this issue Jun 30, 2023 · 1 comment
Closed

Move the getCurrentAlertBanners method to a service #261

andybroomfield opened this issue Jun 30, 2023 · 1 comment
Labels
task
Milestone
v1.8

Comments

@andybroomfield
Copy link
Contributor

This is the method that is currently inside the block class, but if we wanted to call this elsewhere it would be handy to have this as a separate service that can be called, with the block altered to call the service.

It should also be possible to

  • Filter banners by type (currently this is supported by fetching block config)
  • Include additional banners that aren't yet published (For supporting better banner previews)
  • Exclude certain banners
@andybroomfield andybroomfield added this to the v1.8 milestone Nov 24, 2023
andybroomfield added a commit that referenced this issue Jun 24, 2024
@andybroomfield
Move getCurrentBanners to a service
16e7914 
Fix #261

Use a new AlertBannerManager service and move the getCurentBanners method from the
block to the manager service.

Adds an $options array for setting the type and future options.
Small refactor to use loadMultiple.
@andybroomfield andybroomfield mentioned this issue Jun 24, 2024
Merged
@andybroomfield
Copy link
Contributor Author

Fixed in 1.8.x branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
task
Projects
None yet
Milestone
v1.8
Development

No branches or pull requests
1 participant
@andybroomfield