1.7.6 release #326
Merged
1.7.6 release #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
andybroomfield
commented
May 21, 2024
andybroomfield
commented
- Performance improvements. Performance improvements. #321
- Follow up performance improvements Follow up performance improvements #325
- feat: use shared workflow feat: use shared workflow #324
- Fix Translation for alert banner not displaying Fix Translation for alert banner not displaying #319
…nners method so it can be called multiple times without re-loading banners.
…d-unnecessarily Performance improvements.
- fix coding standard
Remove protected array for current banners and move the cache contexts into th build method. Also amend the kernal test to account for #cache inside the render array.
Follow up performance improvements
feat: use shared workflow
Originally authoured by [adinancenci](https://www.drupal.org/u/adinancenci). Applies patch in comment 3. https://www.drupal.org/project/localgov/issues/3427615#comment-15487385
This is to allow the entitiy to remain pure in terms of logic, and the get translation logic in the block. If the alert has a translation use that in place of the alert banner entitiy. This also allows correct checking of visibility Also allows the title to be translated.
Wrap up translation test.
Use the entitiy repositry service to get translation in correct language with fallback.
…upport Fix Translation for alert banner not displaying
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.