Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.7.6 release #326

Merged
merged 15 commits into from
May 21, 2024
Merged

1.7.6 release #326

merged 15 commits into from
May 21, 2024

Commits on May 2, 2024

  1. Stopped block constructor loading entities. Changed getCurrentAlertBa… 

    …nners method so it can be called multiple times without re-loading banners.
    @rupertj
    rupertj committed May 2, 2024
    Configuration menu
    Copy the full SHA
    edaa5a5 View commit details
    Browse the repository at this point in the history

  2. Code style.

    @rupertj
    rupertj committed May 2, 2024
    Configuration menu
    Copy the full SHA
    a6e581d View commit details
    Browse the repository at this point in the history

Commits on May 14, 2024

  1. Merge pull request #321 from localgovdrupal/fix/1.x/320-banners-loade… 

    …d-unnecessarily

Performance improvements.
    @finnlewis
    finnlewis committed May 14, 2024
    Configuration menu
    Copy the full SHA
    0032959 View commit details
    Browse the repository at this point in the history

Commits on May 19, 2024

  1. feat: use shared workflow

    @millnut
    millnut committed May 19, 2024
    Configuration menu
    Copy the full SHA
    c96c9fc View commit details
    Browse the repository at this point in the history

  2. feat: use shared workflow 

    - fix coding standard
    @millnut
    millnut committed May 19, 2024
    Configuration menu
    Copy the full SHA
    ee60547 View commit details
    Browse the repository at this point in the history

Commits on May 21, 2024

  1. Follow up performance improvements 

    Remove protected array for current banners and move the cache contexts
into th build method. Also amend the kernal test to account for #cache
inside the render array.
    @andybroomfield
    andybroomfield committed May 21, 2024
    Configuration menu
    Copy the full SHA
    5fe72a1 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #325 from localgovdrupal/fix/1.x-performance-redux 

    Follow up performance improvements
    @finnlewis
    finnlewis committed May 21, 2024
    Configuration menu
    Copy the full SHA
    c762719 View commit details
    Browse the repository at this point in the history

  3. Merge pull request #324 from localgovdrupal/feature/1.x/shared-workflow 

    feat: use shared workflow
    @finnlewis
    finnlewis committed May 21, 2024
    Configuration menu
    Copy the full SHA
    dec5e46 View commit details
    Browse the repository at this point in the history

  4. Fix Translation for alert banner not displaying 

    Originally authoured by [adinancenci](https://www.drupal.org/u/adinancenci).
Applies patch in comment 3.
  https://www.drupal.org/project/localgov/issues/3427615#comment-15487385
    @andybroomfield
    andybroomfield committed May 21, 2024
    Configuration menu
    Copy the full SHA
    a18ad82 View commit details
    Browse the repository at this point in the history

  5. Move the language selection logic to the block 

    This is to allow the entitiy to remain pure in terms of logic, and the get
translation logic in the block. If the alert has a translation use that in place
of the alert banner entitiy. This also allows correct checking of visibility

Also allows the title to be translated.
    @andybroomfield
    andybroomfield committed May 21, 2024
    Configuration menu
    Copy the full SHA
    909805a View commit details
    Browse the repository at this point in the history

  6. First pass at writing translation test

    @andybroomfield
    andybroomfield committed May 21, 2024
    Configuration menu
    Copy the full SHA
    3ee2a72 View commit details
    Browse the repository at this point in the history

  7. Second pass at translation test with support for paths

    @andybroomfield
    andybroomfield committed May 21, 2024
    Configuration menu
    Copy the full SHA
    3f70503 View commit details
    Browse the repository at this point in the history

  8. cs: fix up translation test 

    Wrap up translation test.
    @andybroomfield
    andybroomfield committed May 21, 2024
    Configuration menu
    Copy the full SHA
    fe94c3a View commit details
    Browse the repository at this point in the history

  9. Replace getTranslation with entityRespositry::getTranslationFromContext 

    Use the entitiy repositry service to get translation in correct language
with fallback.
    @andybroomfield
    andybroomfield committed May 21, 2024
    Configuration menu
    Copy the full SHA
    d2df424 View commit details
    Browse the repository at this point in the history

  10. Merge pull request #319 from localgovdrupal/fix/1.x-318/translation-s… 

    …upport

Fix Translation for alert banner not displaying
    @andybroomfield
    andybroomfield committed May 21, 2024
    Configuration menu
    Copy the full SHA
    e4aff62 View commit details
    Browse the repository at this point in the history