-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added subsites_menu region. #542
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel the following commits would be better in the subsite extras module as documentation/examples rather than being merged into the base theme:
I was in two minds about that myself. |
Hi, I'd prefer the HTML and CSS for this to be in this theme rather than in the module. We can add HTML and CSS to the module as well if we want so that it works even if Keep the variables here means we can place them all in the variables.css file for consistency, and it will make it easier for sub-themes to find them and override them. |
Hi @markconroy |
Hi @dedavidson, Yep, I've noticed that. I'm doing a rewrite of this PR at the moment, hoping to have something ready for it by EOD today, if not, I'll definitely have it ready over the weekend. |
Subsites extras does create a menu called 'subsites' by default on install now. |
I've a pretty major re-write of this done now if anyone wants to review it. I've no JS done yet. Let's get this reviewed and merged and I'll get the JS done then. Also, related PR: localgovdrupal/localgov_scarfolk#36 (it's just one line of code) |
A few small updates since Friday, and the JS added for the menu to toggle on/off on small screens. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cheers mark
No description provided.