Initial move of server to seperate module. #206
Conversation
Working on the same principle as localgovdrupal/localgov_search#34 Has the added bonus of assisting like #201 Would need. Tests altering. I'm thinking that existing tests would require localgov_directories_db. There would be an additional Functional Base Test than any server modules can inherit to check integration (as localgovdrupal/localgov_search#34)
|
This goes with localgovdrupal/localgov_search#40 |
It is 'as if' the _db module was used for installing configuration on existing sites, so making that clear by enabling, but bypassing configuration. The description clarifies the module provides the initial server configuration.
There was a problem hiding this comment.
Looks mostly okay. I have added two minor suggestions.
It may be better to include in the README that the localgov_directories_db module needs to be enabled on a new site for any kind of Directory search to work.
Also, if any other search backend is later enabled and a module similar to localgov_directories_db is installed to support that backend, there could be a conflict over the server setting. So may be better to uninstall localgov_directories_db before switching to a new backend. The README can clarify all these.
modules/localgov_directories_db/localgov_directories_db.install
Outdated
Show resolved
Hide resolved
...les/localgov_directories_db/config/conditional/search_api.index.localgov_sitewide_search.yml
Outdated
Show resolved
Hide resolved
Something like |
Working on the same principle as localgovdrupal/localgov_search#34
Has the added bonus of assisting like #201
Would need. Tests altering.
I'm thinking that existing tests would require localgov_directories_db.
There would be an additional Functional Base Test than any server
modules can inherit to check integration (as
localgovdrupal/localgov_search#34)