Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the form display for the directory promo page #223

Merged
merged 8 commits into from
Sep 26, 2022

Conversation

msayoung
Copy link
Member

@msayoung msayoung commented Sep 8, 2022

No description provided.

@msayoung
Copy link
Member Author

msayoung commented Sep 8, 2022

Before

image

After:

image

  • exposed the summary field (as per other Directory items)
  • changed the banner field display, to not default to select seconday banner paragraph as it caused confusion in testing
  • put the banner and standfirst fields in a fieldset with help text
  • renamed "Content" field to "Layouts and rich content" - updated help text

@msayoung
Copy link
Member Author

msayoung commented Sep 8, 2022

@finnlewis @willguv
Thoughts on the above changes? If you think they are good we can roll them out to Page, Events and News where we have the same.

Particular changes:

  • changed the banner field display, to not default to select seconday banner paragraph as it caused confusion in testing
  • put the banner and standfirst fields in a fieldset with help text
  • renamed "Content" field to "Layouts and rich content" - updated help text

Does it help? Is it clearer?

@finnlewis
Copy link
Member

Thanks @msayoung - all those changes look like good ones to me!

@finnlewis finnlewis marked this pull request as ready for review September 26, 2022 10:19
Copy link
Member

@finnlewis finnlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, and works as advertised. The form is certainly tidier and I expect easier to use.

Tests all pass and this is only for new installs.

Thanks @msayoung !

@msayoung msayoung merged commit a218119 into 2.x Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants