-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update config to allow the primary banner as an option on the banner … #230
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've a suggestion to simplify the config, otherwise works fine
@@ -21,6 +22,7 @@ settings: | |||
handler: 'default:paragraph' | |||
handler_settings: | |||
target_bundles: | |||
localgov_banner_primary: localgov_banner_primary | |||
localgov_banner_secondary: localgov_banner_secondary | |||
negate: 0 | |||
target_bundles_drag_drop: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think you need all the disabled target_bundles_drag_drop
items; they are referencing paragraph types that may not exist.
I suggest removing all the items with enabled: false
, shortening this to
target_bundles_drag_drop:
localgov_banner_primary:
weight: 0
enabled: true
localgov_banner_secondary:
weight: 1
enabled: true
There is another PR removing the secondary banner as the default option also contains some other improvements. |
I've made those improvements @stephen-cox |
…field