Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Address lookup caching #70

Draft
wants to merge 1 commit into
base: 1.x
Choose a base branch
from
Draft

Conversation

Adnan-cds
Copy link
Contributor

@Adnan-cds Adnan-cds commented Mar 7, 2024

The newly added local custodian code restriction should also be considered when opting to use cached results from previous address lookups. This is particularly useful when there are multiple address lookup elements in a form but they are using different local custodian codes.

Test steps

  • Add two address lookup elements to a Webform.
  • When configuring the above address lookup elements, choose different Local authorities from the Local authority dropdown.
  • Open the Webform and do address lookups on both address lookup elements. Use the same search string such as "sandown".
  • Returned address lists should differ due to the difference in local authorities.

Todos

  • Automated test.

The newly added local custodian code restriction should also be considered when
opting to use cached results from previous address lookups.  This is
particularly useful when there are multiple address lookup elements in a form
but they are using different local custodian codes.
@Adnan-cds Adnan-cds added the bug Something isn't working label Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant