Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add main and utility group menus #16

Merged
merged 2 commits into from
May 9, 2022
Merged

Conversation

stephen-cox
Copy link
Member

@ekes
Copy link
Member

ekes commented May 9, 2022

I was going to suggest adding the default admin permissions to this PR. But I'm going to spin it out into a new issue #26

At the moment the menu content menu only exposes permissions for the menu itself (confusingly identified as for one menu when it's all the menus) and doesn't expose any permission for adding menu items (and uses the rather far-reaching Administer group permission for this).

So approving as all the rest works, and we need to sort permissions elsewhere.

Copy link
Member

@ekes ekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see #26 for follow-up.

@stephen-cox stephen-cox merged commit 1071361 into 1.x May 9, 2022
@stephen-cox stephen-cox deleted the feature/39-group-menus branch May 9, 2022 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants