-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed dependency on ck4 via patch to footnotes module. Changed install config for supplied editor to use ck5. #117
Conversation
…all config for supplied editor to use ck5.
Thanks @rupertj
|
Thanks @rupertj - we'll try to test it soon |
@rupertj - can confirm I'm seeing the same behaviour as Andy.
Also, not sure if the switch from paratest to phpunit in github workflow was intentional? |
@rupertj sounds like this isn't quite working as intended. You got time this week to look at it again? |
This was intentional. Paratest wasn't handling unit test failure properly, which was getting annoying. For example: This is actually one of the unit tests failing, but instead of getting the test fail message, that error shows up. Using PHPUnit instead of Paratest shows the test failure properly: |
Fixes #95