Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checks fields exist on node in header block before using them. #127

Merged
merged 2 commits into from
Jan 17, 2024
Merged

Checks fields exist on node in header block before using them. #127

merged 2 commits into from
Jan 17, 2024

Conversation

rupertj
Copy link
Member

@rupertj rupertj commented Jan 7, 2024 •
edited
Loading

Fixes #115

@finnlewis finnlewis self-assigned this Jan 16, 2024
finnlewis
finnlewis approved these changes Jan 17, 2024
View reviewed changes
Copy link
Member

@finnlewis finnlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, confirmed the original error on the 1.x branch and error is gone on this branch. Lovely! Thanks @rupertj - I'll merge it!

@finnlewis finnlewis merged commit b30560c into 1.x Jan 17, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@finnlewis finnlewis finnlewis approved these changes

Assignees

@finnlewis finnlewis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Publications header block breaks the site if on wrong content types
2 participants
@rupertj @finnlewis