Added layout paragraphs to publication content types instead of existing content fields. #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing content fields.
|
Looking at the config dependency errors @rupertj , I think we might need to require layout_paragraphs in composer.json |
|
Yeah, you're probably right. Cheers for spotting that, although I wasn't expecting anyone to review this yet :) |
|
Hey @rupertj - sorry, no worries! I'm just taking advantage of Merge Mondays moving to Merge Tuesdays... so rattle through the list of pull requests at https://github.com/pulls?q=is%3Aopen+is%3Apr+archived%3Afalse+user%3Alocalgovdrupal+draft%3Afalse We also can mark pull requests as draft if we want to do more work before review, then they don't show up in that list. |
…t, so we get layouts if you only enable publications on a site.
|
@finnlewis Tests are green, and my own manual testing looks good. Could you give this a look? Ta. |
|
Testing now! Sorry not to get to it sooner @rupertj |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #74