Stops empty ToC block appearing when no headings to link to are found. #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. Adds undeclared dependencies. Adds test for TocBlock.
rupertj
requested review from
jbloomfield,
finnlewis and
j4-m
and removed request for
jbloomfield and
finnlewis
finnlewis
requested changes
Mar 22, 2023
There was a problem hiding this comment.
Also, we've not got the default github workflows tests running yet, so worth running phpcs locally.
Just did and there are a few coding standards things to fix:
finn@Oobuntoo:~/sites/l.localgov/MY_PROJECT$ lando phpcs web/modules/contrib/localgov_publications/
............................................EE...W.E.. 54 / 54 (100%)
FILE: ...les/contrib/localgov_publications/localgov_publications.info.yml
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
14 | ERROR | [x] Expected 1 newline at end of file; 2 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
FILE: ...trib/localgov_publications/tests/src/Functional/TocBlockTest.php
----------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 4 LINES
----------------------------------------------------------------------
33 | ERROR | [x] Missing function doc comment
48 | ERROR | [x] There must be exactly one blank line before the
| | tags in a doc comment
74 | ERROR | [x] Expected 1 blank line after function; 0 found
75 | ERROR | [x] The closing brace for the class must have an empty
| | line before it
----------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
FILE: ...dules/contrib/localgov_publications/localgov_publications.module
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
44 | WARNING | Line exceeds 80 characters; contains 82 characters
----------------------------------------------------------------------
FILE: ...ules/contrib/localgov_publications/localgov_publications.install
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
1 | ERROR | [x] Missing file doc comment
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
Time: 801ms; Memory: 12MB
config/optional/block.block.localgov_publications_toc_block.yml
Outdated
Show resolved
Hide resolved
|
The block visibility does work though, so thanks, for this! 😺 |
|
I've merged 1.x in here with the proper CI pipeline setup, so we should see the tests pass in a bit... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #37.