Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document custom ssl certificate #404

Merged
merged 12 commits into from Dec 15, 2022
Merged

Conversation

simonrw
Copy link
Contributor

@simonrw simonrw commented Dec 13, 2022

Add documentation for supporting custom SSL certificates. This is needed for some users behind corporate networks with SSL intercepting proxy servers.

Rendered

@github-actions
Copy link

github-actions bot commented Dec 13, 2022

🎊 PR Preview has been successfully built and deployed to https://localstack-docs-preview-pr-404.surge.sh 🎊

Signed-off-by: Simon Walker <simon.walker@localstack.cloud>
@simonrw simonrw marked this pull request as ready for review December 14, 2022 11:13
Copy link
Member

@alexrashed alexrashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great docs on how to configure your custom certificate authority!
I only found some nitpicks and a typo unrelated to the changes here, afterwards we're good to merge!
It also seems that the preview deployment broke, but that might as well just be a small flake with the surge deployment.

content/en/references/init-hooks.md Outdated Show resolved Hide resolved
content/en/references/custom-ssl-certificates.md Outdated Show resolved Hide resolved
content/en/references/custom-ssl-certificates.md Outdated Show resolved Hide resolved
Copy link
Member

@alexrashed alexrashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks for the nice guide! This will help quite a lot of people behind (corporate) proxies!
And the markdown style and the commits are great (one line per sentence in markdown, one commit per change)! 🚀

@simonrw simonrw merged commit 156be24 into main Dec 15, 2022
@simonrw simonrw deleted the document-custom-ssl-certificate branch December 15, 2022 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants