Allow setting the ingress class via spec.ingressClassName
#118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: localstack#114 The annotation `kubernetes.io/ingress.class` is deprecated and shouldn't be used for specifying the ingress class. Instead the option `ingressClassName` should be used. This introduces that as an option to values and adds additional annotation comments for enabling SSL passthrough when nginx is used as an ingress controller As a result of this change, in local testing the following side effects were observed:
alexrashed
reviewed
Apr 24, 2024
There was a problem hiding this comment.
Thanks a lot for your contribution, @mproffitt!
I only found two small nitpicks (cleaning up the old annotation comments for the ingress class, and a superfluous line break). Afterwards we are good to go, and I'll merge and release this change! 🚀
- Remove comment block from values.yaml relating to deprecated settings - Remove superfluous line break
alexrashed
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #114
The annotation
kubernetes.io/ingress.classis deprecated and shouldn't be used for specifying the ingress class.Instead the option
ingressClassNameshould be used. This introduces that as an option to values and adds additional annotation comments for enabling SSL passthrough when nginx is used as an ingress controllerAs a result of this change, in local testing the following side effects were observed:
Motivation
Changes