Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow setting the ingress class via spec.ingressClassName #118

Merged
merged 3 commits into from
Apr 24, 2024
Merged

Allow setting the ingress class via spec.ingressClassName #118

merged 3 commits into from
Apr 24, 2024

Commits on Apr 24, 2024

  1. Allow setting the ingress class via spec.ingressClassName 

    Fixes: localstack#114

The annotation `kubernetes.io/ingress.class` is deprecated and shouldn't
be used for specifying the ingress class.

Instead the option `ingressClassName` should be used. This introduces
that as an option to values and adds additional annotation comments for
enabling SSL passthrough when nginx is used as an ingress controller

As a result of this change, in local testing the following side effects
were observed:
    @mproffitt
    mproffitt committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    5edd028 View commit details
    Browse the repository at this point in the history

  2. Code cleanup 

    - Remove comment block from values.yaml relating to deprecated settings
- Remove  superfluous line break
    @mproffitt
    mproffitt committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    7e7aeef View commit details
    Browse the repository at this point in the history

  3. Update wording on comment

    @mproffitt
    mproffitt committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    4cddb4e View commit details
    Browse the repository at this point in the history