Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

raise exception if required ENV is missing #10568

Merged
merged 1 commit into from
Mar 28, 2024
Merged

raise exception if required ENV is missing #10568

merged 1 commit into from
Mar 28, 2024

Conversation

steffyP
Copy link
Member

@steffyP steffyP commented Mar 28, 2024

Motivation

The helper script to upload tinybird coverage metrics was silently failing on ext, as we only had a return statement if any ENV was missing.

Changes

  • raise Exception if required ENV is missing to fail the workflow

@steffyP steffyP added the semver: patch Non-breaking changes which can be included in patch releases label Mar 28, 2024
@steffyP steffyP requested a review from silv-io March 28, 2024 14:59
silv-io
silv-io approved these changes Mar 28, 2024
View reviewed changes
Copy link
Member

@silv-io silv-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for fixing this :)

@steffyP steffyP merged commit 4490408 into master Mar 28, 2024
22 of 23 checks passed
@steffyP steffyP deleted the fail-for-missing-env branch March 28, 2024 17:07
@alexrashed alexrashed mentioned this pull request Apr 12, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silv-io silv-io silv-io approved these changes

Assignees
No one assigned
Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@steffyP @silv-io