Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix healthcheck in dockerfile #10894

Merged
merged 2 commits into from
May 24, 2024
Merged

fix healthcheck in dockerfile #10894

merged 2 commits into from
May 24, 2024

Conversation

thrau
Copy link
Member

@thrau thrau commented May 24, 2024

Motivation

As a user pointed out in #10893 (comment), the healthcheck command was faulty after #10800:

thomas@ninox /tmp/foo % docker exec -it foo-localstack-1 bash
root@cb3bded7f1f7:/opt/code/localstack# ./bin/localstack status services 
Traceback (most recent call last):
  File "/opt/code/localstack/./bin/localstack", line 23, in <module>
    main()
  File "/opt/code/localstack/./bin/localstack", line 17, in main
    from localstack.cli import main
ModuleNotFoundError: No module named 'localstack'

I'm deliberately not fixing bin/localstack because I believe we should not be using it directly in this way.

I also noticed that rolo is logging HTTP health check requests again, so I updated the default log levels to what we had in localstack.aws.serving.

Changes

  • HEALTHCHECK in Dockerfile now uses localstack from the .venv instead the plain script, which uses the correct pythonpath
  • default log levels for rolo is now WARNING and DEBUG only for tracing

@thrau thrau requested a review from alexrashed as a code owner May 24, 2024 19:25
@thrau thrau added the semver: patch Non-breaking changes which can be included in patch releases label May 24, 2024
@dominikschubert dominikschubert self-requested a review May 24, 2024 19:42
Copy link
Member

@dominikschubert dominikschubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested locally as well to make sure it works. Was confused at first why that should work but looking at the contents of the script it makes sense 🙃

@thrau thrau merged commit e9b53d9 into master May 24, 2024
19 of 28 checks passed
@thrau thrau deleted the fix-health-check branch May 24, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants