Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix S3 image healthcheck #10970

Merged
merged 1 commit into from
Jun 6, 2024
Merged

fix S3 image healthcheck #10970

merged 1 commit into from
Jun 6, 2024

Conversation

bentsku
Copy link
Contributor

@bentsku bentsku commented Jun 6, 2024

Motivation

As reported and fixed in #10969, the S3 image health check had not been migrated following the refactoring/move into localstack-core (#10800). The fix is the same as #10894, and is now ported to the S3 image as well.

The original PR could not merge quickly due to the CLA, but in order to unblock the S3 image, we can merge this quicker.
Thanks again to @krishanbhasin-px for the fix.

Changes

  • pick the health check from the regular localstack Dockerfile

@bentsku bentsku added the semver: patch Non-breaking changes which can be included in patch releases label Jun 6, 2024
@bentsku bentsku self-assigned this Jun 6, 2024
Copy link

github-actions bot commented Jun 6, 2024

S3 Image Test Results (AMD64 / ARM64)

  2 files    2 suites   3m 5s ⏱️
404 tests 354 ✅  50 💤 0 ❌
808 runs  708 ✅ 100 💤 0 ❌

Results for commit 72101ef.

Copy link
Member

@alexrashed alexrashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix, and thanks to @krishanbhasin-px for pointing us to it. Since this issue might block a lot of other people, I agree that we should move somewhat fast on this.
It's a pity that we can't give the credit to you (by merging the original PR / getting your code in directly), but maybe you can get the approval and find something else to fix. 😛

Copy link
Member

@thrau thrau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️ Please add @krishanbhasin-px as co-author to the PR (Use the Co-Author syntax in the commit message)

@localstack-bot
Copy link
Collaborator


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@bentsku bentsku merged commit bc26ebd into master Jun 6, 2024
4 of 5 checks passed
@bentsku bentsku deleted the fix-s3-image-healthcheck branch June 6, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants