Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add map, quiet return functions for VTL template rendering #6035

Merged
merged 2 commits into from
May 10, 2022

Conversation

whummer
Copy link
Member

@whummer whummer commented May 9, 2022

Small enhancements for Velocity rendering, continuation of fixes for #5988 :

  • add proper support for map functions put/putAll
  • add quiet/qr util function to suppress output from function results
  • minor refactoring, pulling out VelocityUtil base functionality into common base class

@whummer whummer requested a review from calvernaz May 9, 2022 14:52
@whummer whummer temporarily deployed to localstack-ext-tests May 9, 2022 14:53 Inactive
stage_var = variables.get("stage_variables") or {}
namespace = {
"context": context_var,
"stageVariables": stage_var,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moving stageVariables to VelocityUtilApiGateway, as this is API GW specific and does not belong into the common base class.

@whummer whummer temporarily deployed to localstack-ext-tests May 9, 2022 15:06 Inactive
@github-actions
Copy link

github-actions bot commented May 9, 2022

LocalStack integration with Pro

       3 files  ±0         3 suites  ±0   1h 12m 5s ⏱️ -4s
1 011 tests ±0     970 ✔️ ±0  41 💤 ±0  0 ±0 
1 307 runs  ±0  1 239 ✔️ ±0  68 💤 ±0  0 ±0 

Results for commit c976eee. ± Comparison against base commit b2adf0b.

Copy link
Contributor

@calvernaz calvernaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another great job, thanks!

@whummer whummer merged commit 4ec0bbe into master May 10, 2022
@whummer whummer deleted the vtl-map-return branch May 10, 2022 19:46
@github-actions github-actions bot locked and limited conversation to collaborators May 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants