Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor: Add test dependency to deepdiff #6401

Merged
merged 1 commit into from
Jul 5, 2022
Merged

minor: Add test dependency to deepdiff #6401

merged 1 commit into from
Jul 5, 2022

Conversation

whummer
Copy link
Member

@whummer whummer commented Jul 5, 2022

Add test dependency to deepdiff. This library is being used in the testing.snapshots package, and we are currently depending on it transitively via -ext. This dependency is going to be removed upstream, hence adding it here directly.

@whummer whummer temporarily deployed to localstack-ext-tests July 5, 2022 07:21 Inactive
@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 91.419% when pulling b5b792a on dep-deepdiff into eba8880 on master.

@github-actions
Copy link

github-actions bot commented Jul 5, 2022

LocalStack integration with Pro

       3 files         3 suites   1h 8m 42s ⏱️
1 115 tests 1 075 ✔️ 40 💤 0
1 426 runs  1 357 ✔️ 69 💤 0

Results for commit b5b792a.

@whummer whummer requested a review from thrau July 5, 2022 09:35
Copy link
Member

@thrau thrau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@whummer whummer merged commit 28ddb0d into master Jul 5, 2022
@whummer whummer deleted the dep-deepdiff branch July 5, 2022 09:38
@localstack localstack locked and limited conversation to collaborators Jul 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants