Moto v4 #6430
Merged
Moto v4 #6430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viren-nadkarni
force-pushed
the
multi-accounts-mk2
branch
from
bb3af84
to
c996a82
Compare
ACM, APIGW, CW, EC2, KMS, S3, Secrets Manager
viren-nadkarni
force-pushed
the
multi-accounts-mk2
branch
from
c996a82
to
aff17ac
Compare
Merged
It is to be used in tests only
Moto v4 removes the indirection handler. Account ID is passed as a header
Caused by getmoto/moto#5397
This reverts commit 1e1afb2.
|
short log of what i did:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds full support for Moto v4 and multi-accounts for Moto-backed services.
Revert these commits before merge: 1e1afb2 (@thrau: done!)