fix SNS publish_batch passing MessageDeduplicationId to SQS queue #6660
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #6657
We only checked
ContentBasedDeduplication
settings in our tests forpublish_batch
.We would not pass the
MessageDeduplicationId
to the SQS queue, thus launching this exception:This reinforces the need for a refactoring of the SNS provider.
We are not directly enforcing the deduplication in SNS, but instead piggy back on SQS.
The behaviour of SNS is a bit different, see: https://docs.aws.amazon.com/sns/latest/dg/fifo-message-dedup.html, with a time window of 5 minutes. This will need to be implemented in a follow up iteration.