Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update RedHat example Dockerfile #7047

Merged
merged 3 commits into from
Oct 21, 2022
Merged

update RedHat example Dockerfile #7047

merged 3 commits into from
Oct 21, 2022

Conversation

alexrashed
Copy link
Member

@alexrashed alexrashed commented Oct 19, 2022

This PR tries to revive our RedHat Dockerfile example located in Dockerfile.rh.
The workflow has been deactivated due to several issues over the time (python upgrades, filesystem changes, certain non-redhat compatible installers,...).
With our new installer structure (introduced in #6783), these issues can now be addressed.
This PR also changes the trigger of the pipeline from being executed on every master build to be executed on a schedule (every week) since it only tests the latest dev releases against each other (and therefore doesn't directly test the latest commit on the master).

Unfortunately, the pipeline can't really be tested (since it had no workflow trigger before). I tested the steps locally though.

@alexrashed alexrashed temporarily deployed to localstack-ext-tests October 19, 2022 15:31 Inactive
@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 79.387% when pulling 407950d on fix-redhat-image-build into bd640bf on master.

@github-actions
Copy link

github-actions bot commented Oct 19, 2022

LocalStack integration with Pro

       3 files         3 suites   1h 13m 28s ⏱️
1 412 tests 1 229 ✔️ 183 💤 0
2 010 runs  1 595 ✔️ 415 💤 0

Results for commit c437d5f.

♻️ This comment has been updated with latest results.

@alexrashed alexrashed temporarily deployed to localstack-ext-tests October 20, 2022 07:35 Inactive
@alexrashed alexrashed temporarily deployed to localstack-ext-tests October 20, 2022 09:44 Inactive
@alexrashed alexrashed marked this pull request as ready for review October 20, 2022 09:47
@alexrashed alexrashed temporarily deployed to localstack-ext-tests October 20, 2022 11:08 Inactive
@alexrashed alexrashed requested a review from thrau October 20, 2022 12:12
Copy link
Member

@thrau thrau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome! 💯

@alexrashed alexrashed merged commit 903cfe2 into master Oct 21, 2022
@alexrashed alexrashed deleted the fix-redhat-image-build branch October 21, 2022 06:29
cmoralesmx pushed a commit to cmoralesmx/localstack that referenced this pull request Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants