-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update lambda runtime init version, add config option for timeouts #7087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thrau
approved these changes
Oct 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…time exception to abc module
dfangl
force-pushed
the
lambda-kubernetes
branch
from
October 25, 2022 11:44
9cb396c
to
5ddbee6
Compare
dominikschubert
approved these changes
Oct 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We released a new version of the lambda runtime init, which we will now update to.
Also, the LambdaRuntimeException is better suited to live in the runtime_executor module (due to it potentially being used by multiple executor implementations).
And, for different executors, a config variable for the runtime environment timeout comes in handy.
Also, when an error is thrown in the start() method, we until now did not set this environment to failed, and stop any executor that might be running.
Changes
LAMBDA_RUNTIME_ENVIRONMENT_TIMEOUT
config, which tells us the default timeout for an environment to report back (before it is killed and restarted). The default is 10, which should be enough for docker, but other executors might need more time here.LambdaRuntimeException
to runtime_executor module