Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lambda runtime init version, add config option for timeouts #7087

Merged
merged 6 commits into from
Oct 27, 2022

Conversation

dfangl
Copy link
Member

@dfangl dfangl commented Oct 25, 2022

Motivation

We released a new version of the lambda runtime init, which we will now update to.
Also, the LambdaRuntimeException is better suited to live in the runtime_executor module (due to it potentially being used by multiple executor implementations).
And, for different executors, a config variable for the runtime environment timeout comes in handy.
Also, when an error is thrown in the start() method, we until now did not set this environment to failed, and stop any executor that might be running.

Changes

  • Add LAMBDA_RUNTIME_ENVIRONMENT_TIMEOUT config, which tells us the default timeout for an environment to report back (before it is killed and restarted). The default is 10, which should be enough for docker, but other executors might need more time here.
  • Move LambdaRuntimeException to runtime_executor module
  • Update runtime init to 0.1.5-pre.
  • Add error handling to calls of RuntimeExecutor.start()

@dfangl dfangl temporarily deployed to localstack-ext-tests October 25, 2022 08:48 Inactive
@dfangl dfangl temporarily deployed to localstack-ext-tests October 25, 2022 08:49 Inactive
@github-actions
Copy link

github-actions bot commented Oct 25, 2022

LocalStack integration with Pro

       3 files  ±0         3 suites  ±0   1h 13m 42s ⏱️ -52s
1 417 tests ±0  1 228 ✔️  - 1  189 💤 +1  0 ±0 
2 015 runs  ±0  1 594 ✔️  - 1  421 💤 +1  0 ±0 

Results for commit 5ddbee6. ± Comparison against base commit a384434.

♻️ This comment has been updated with latest results.

@dfangl dfangl temporarily deployed to localstack-ext-tests October 25, 2022 09:12 Inactive
@dfangl dfangl temporarily deployed to localstack-ext-tests October 25, 2022 10:05 Inactive
Copy link
Member

@thrau thrau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dfangl dfangl temporarily deployed to localstack-ext-tests October 25, 2022 11:45 Inactive
@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 79.333% when pulling 5ddbee6 on lambda-kubernetes into a384434 on master.

Copy link
Member

@dominikschubert dominikschubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dfangl dfangl merged commit 9791ad7 into master Oct 27, 2022
@dfangl dfangl deleted the lambda-kubernetes branch October 27, 2022 08:30
@dfangl dfangl restored the lambda-kubernetes branch October 27, 2022 08:30
@dfangl dfangl deleted the lambda-kubernetes branch October 27, 2022 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants