Extract AWS Account ID from IAM access key ids (again) #8138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bentsku
reviewed
Apr 13, 2023
localstack-bot
force-pushed
the
release/v2.1
branch
from
3aa30ae
to
adfe847
Compare
localstack-bot
force-pushed
the
release/v2.1
branch
11 times, most recently
from
f4b05b5
to
7384da3
Compare
dfangl
force-pushed
the
iam-account-extraction
branch
from
12988fb
to
67e98d0
Compare
dominikschubert
approved these changes
Apr 21, 2023
|
Why are 5 files changed to revert a change to 2 files? 😄 It looks like this adds a new config PARITY_AWS_ACCESS_KEY_ID Is it possible now to force localstack to use the 0's default id in all cases and not complain about receiving a real "production" id? It looks like PARITY_AWS_ACCESS_KEY_ID provides a way to use the real id and not complain about it... Where are these different options documented? |
|
@joebowbeer: Thanks for highlighting the missing docs, it is being added with localstack/docs#613 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reintroduces changes made with #7045
Motivation
We still need to properly extract the account id from the IAM access key id, and its already encoded properly in there.
On the first try, we encountered issues with users having real AWS credentials in their environment, which led to several problems, as suddenly they were using multi account.
Changes
Linstead of anA. So, for account000000000000a user access key would beLKIAQAAAAAAALILNVHFSinstead ofAKIAQAAAAAAALILNVHFS. This allows us to distinguish AWS credentials from LocalStack credentials, while leaving the rest of the access key id format identical.This depends on getmoto/moto#6210 for a bugfix affecting the tests.