Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix PutEvents non-existent custom EventBus #8264

Merged
merged 4 commits into from
May 12, 2023
Merged

Conversation

bentsku
Copy link
Contributor

@bentsku bentsku commented May 5, 2023

This PR would fix #8261
AWS allows publishing an Event to a nonexistent custom EventBus, it will just accept it and not do anything with it, as the test demonstrates (we even try to describe the nonexistent custom EventBus and it raises an error)

@bentsku bentsku self-assigned this May 5, 2023
@bentsku bentsku added aws:events Amazon EventBridge semver: patch Non-breaking changes which can be included in patch releases labels May 5, 2023
@coveralls
Copy link

coveralls commented May 5, 2023

Coverage Status

Coverage: 82.278% (-0.007%) from 82.285% when pulling 8672564 on fix-key-error-events into e1d4725 on master.

@github-actions
Copy link

github-actions bot commented May 5, 2023

LocalStack Community integration with Pro

2 039 tests   1 758 ✔️  1h 12m 52s ⏱️
       2 suites     281 💤
       2 files           0

Results for commit 8672564.

♻️ This comment has been updated with latest results.

Copy link
Member

@dfangl dfangl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

tests/integration/test_events.py Outdated Show resolved Hide resolved
@bentsku bentsku merged commit 0e8a7be into master May 12, 2023
@bentsku bentsku deleted the fix-key-error-events branch May 12, 2023 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aws:events Amazon EventBridge semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: events.PutEvents fails with custom bus name using boto3
3 participants